Add first EventTime maker task #300
Conversation
njacazio
force-pushed
the
nj-t0tof
branch
6 times, most recently
from
b649a85 to
37cc0e7
Compare
|
Some of #316 are already included here |
|
This depends also on AliceO2Group/AliceO2#7683 |
|
And waits AliceO2Group/AliceO2#7679 to be merged so as to change the include and avoid issues in the CI |
njacazio
requested review from
a team,
alibuild,
iarsene,
jgrosseo and
ktf
as code owners
njacazio
force-pushed
the
nj-t0tof
branch
3 times, most recently
from
aa79f5c to
b8d5738
Compare
|
@jgrosseo with last commit I ensure compatibility with Run2 converted data, therefore alisw/AliPhysics#19008 is not needed anymore (I'm closing it). |
| bool isPidTableRequired(o2::framework::InitContext& initContext, const std::string table) | ||
| { | ||
| auto& workflows = initContext.services().get<o2::framework::RunningWorkflowInfo const>(); | ||
| for (auto device : workflows.devices) { | ||
| for (auto input : device.inputs) { | ||
| if (input.matcher.binding == table) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Shall we move this to Common/Core/TableHelpers.h or so?
|
|
||
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| auto workflow = WorkflowSpec{adaptAnalysisTask<tofSignal<false>>(cfgc), |
There was a problem hiding this comment.
Is the only difference between the Run 2 and Run 3 workflow the true or false?
In the future the run 2 and run 3 should be decided by the AOD metadata and therefore it would be better if it is in the same file and just configures itself based on a PROCESS_SWITCH for now...
|
#378 Should be merged first as it contains the TPC part |
|
Major cleanup of the PR with splitting in sub PRs: Tested with AODs obtained with: AliceO2Group/AliceO2#7782 that fixes the information written in the AOD for the BC subraction and PID hypothesis in tracking |
| template <typename trackType> | ||
| bool filterForTOFEventTime(const trackType& tr) | ||
| { | ||
| return (tr.hasTOF() && tr.p() > 0.5f && tr.p() < 2.f && tr.trackType() == o2::aod::track::TrackTypeEnum::Track); |
There was a problem hiding this comment.
So this work only for Run 3 tracks. Is this correct?
There was a problem hiding this comment.
Yes, this is intended, one could have a separate filter for the Run2 but in principle TOF is already used for the T0 determination and the info is kept in the Run2 AOD
jgrosseo
left a comment
jgrosseo
left a comment
There was a problem hiding this comment.
Fine, except my question.
- Add Run3 PID response using TOF event time inside TOF full task - Add utility to compute TOF mass - Extend documentation - Use common utils for TOF PID task - Extend documentation, extensive use of static methods in PIDTOF - Add expected signal dynamic columns - Computing tofSignal independently - Include Run2 compatibility for TOF response for the exp signal computation with pExp/kCSPEED - Remove requirement of TrackCov
|
Conflicts are resolved, this is also now ready to be merged |
- Add Run3 PID response using TOF event time inside TOF full task - Add utility to compute TOF mass - Extend documentation - Use common utils for TOF PID task - Extend documentation, extensive use of static methods in PIDTOF - Add expected signal dynamic columns - Computing tofSignal independently - Include Run2 compatibility for TOF response for the exp signal computation with pExp/kCSPEED - Remove requirement of TrackCov
* PWGLF: add occupancy in time range to str der data * Please consider the following formatting changes (#300) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* PWGLF: add occupancy in time range to str der data * Please consider the following formatting changes (AliceO2Group#300) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
3 participants
Extend Efficiency task
Extend track selection task
Fix warning in pidBayes